Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voxel artifacts when clipping past bounds #11005

Open
lilleyse opened this issue Jan 4, 2023 · 0 comments
Open

Voxel artifacts when clipping past bounds #11005

lilleyse opened this issue Jan 4, 2023 · 0 comments

Comments

@lilleyse
Copy link
Contributor

lilleyse commented Jan 4, 2023

The clipping bounds should never be allowed to exceed the bounds, but that seems to be happening with cylinders and ellipsoids.

clipping-bug

Sandcastle

The best place to start looking is here:

const renderMinAngle = Math.max(shapeMinAngle, clipMinAngle);
const renderMaxAngle = Math.min(shapeMaxAngle, clipMaxAngle);

This is actually a somewhat hard problem

  • This code does not handle the -pi / pi discontinuity properly
  • In theory clipping should be able to produce a two-wedge shape like below, but this requires significant shader changes

IMG_20221230_161017162-clipped

(Black = bounds, magenta = clipping bounds)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment