Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics): Expose modular API that matches the Firebase web JS SDK v9 API #6816

Merged
merged 15 commits into from
Feb 15, 2023

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jan 4, 2023

Description

Expose modular API that matches the Firebase web JS SDK v9 API.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Jan 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 15, 2023 at 6:56PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Feb 15, 2023 at 6:56PM (UTC)
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #6816 (9feb2e6) into main (bf02676) will decrease coverage by 17.21%.
The diff coverage is 7.15%.

@@              Coverage Diff              @@
##               main    #6816       +/-   ##
=============================================
- Coverage     71.11%   53.90%   -17.21%     
- Complexity        0      718      +718     
=============================================
  Files           125      228      +103     
  Lines          5057    11303     +6246     
  Branches       1123     1812      +689     
=============================================
+ Hits           3596     6092     +2496     
- Misses         1372     4877     +3505     
- Partials         89      334      +245     
@russellwheatley russellwheatley marked this pull request as ready for review January 5, 2023 10:11
@russellwheatley
Copy link
Member Author

What do you think, @mikehardy? There's a few APIs on the new modular API that don't have a corresponding API for native. So they'll have to be wired up when web becomes available on react native I guess. I've also modularised the helper methods for logging events 😄.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - all the web-only stuff seems like what a mythical "reasonable developer" would expect.

@mikehardy mikehardy merged commit a42551a into main Feb 15, 2023
@mikehardy mikehardy deleted the feat/modular-analytics branch February 15, 2023 19:47
exaby73 pushed a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants