-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(analytics): Expose modular API that matches the Firebase web JS SDK v9 API #6816
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Codecov Report
@@ Coverage Diff @@
## main #6816 +/- ##
=============================================
- Coverage 71.11% 53.90% -17.21%
- Complexity 0 718 +718
=============================================
Files 125 228 +103
Lines 5057 11303 +6246
Branches 1123 1812 +689
=============================================
+ Hits 3596 6092 +2496
- Misses 1372 4877 +3505
- Partials 89 334 +245 |
What do you think, @mikehardy? There's a few APIs on the new modular API that don't have a corresponding API for native. So they'll have to be wired up when web becomes available on react native I guess. I've also modularised the helper methods for logging events 😄. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - all the web-only stuff seems like what a mythical "reasonable developer" would expect.
Description
Expose modular API that matches the Firebase web JS SDK v9 API.
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter