You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #3087 (comment), I detailed what seems to be a compiler bug. This code in lib/dash/dash_parser.js triggers the bug:
// Attach trick mode tracks to normal tracks.for(consttrickModeSetoftrickModeAdaptationSets){consttargetIds=trickModeSet.trickModeFor.split(' ');for(constnormalSetofnormalAdaptationSets){if(targetIds.includes(normalSet.id)){for(conststreamofnormalSet.streams){constMimeUtils=shaka.util.MimeUtils;// There may be multiple trick mode streams, but we do not// currently support that. Just choose one.// TODO: https://github.com/google/shaka-player/issues/1528stream.trickModeVideo=trickModeSet.streams.find((trickStream)=>MimeUtils.getCodecBase(stream.codecs)==MimeUtils.getCodecBase(trickStream.codecs));}}}}
The compiler's iterator polyfill is in play here, as well as an alias which is not directly referenced in scope, but only in a synchronous callback.
Since we can't fix the compiler, and we can't audit the whole codebase for this sort of thing by hand, we need to try to write either an eslint rule or a Closure compiler conformance rule to detect and ban this pattern.
The text was updated successfully, but these errors were encountered:
In #3087 (comment), I detailed what seems to be a compiler bug. This code in lib/dash/dash_parser.js triggers the bug:
The compiler's iterator polyfill is in play here, as well as an alias which is not directly referenced in scope, but only in a synchronous callback.
Since we can't fix the compiler, and we can't audit the whole codebase for this sort of thing by hand, we need to try to write either an eslint rule or a Closure compiler conformance rule to detect and ban this pattern.
The text was updated successfully, but these errors were encountered: