Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation and readability in Scene and depth-related code #12188

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
+1,347 −1,285
Open

Improve documentation and readability in Scene and depth-related code #12188

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
875e0a8
Update PostProcessStageCollection to follow Coding Guide
Sep 10, 2024
52da7fd
Clean up DerivedCommand
Sep 10, 2024
4daa78e
More cleanup in Scene, View, PostProcessStage, GlobeDepth
Sep 10, 2024
faa07f7
Cleanup PostProcessStage, Scene, add docs in View
Sep 10, 2024
2d6ea50
Edit docs related to depth buffers
Aug 28, 2024
ad274f8
Fix spec failure
Aug 28, 2024
e36f1cf
Simplify executeCommand signature in Scene
Aug 28, 2024
22bf29b
Clarify docs and calculations for projection matrices
Aug 30, 2024
05d9864
Document more private functions in Scene
Sep 10, 2024
e250d72
Update Framebuffer to follow current CodingGuide
Sep 5, 2024
854907b
Add docs, simplify signatures for depth buffers
Sep 10, 2024
611bcca
Incorporate ideas from PR 12058
Sep 11, 2024
0350152
Address TODO comment
Sep 12, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Document more private functions in Scene
  • Loading branch information
Jeshurun Hembd committed Sep 10, 2024
commit 05d98644f47a6dbe103197f90de87860536d6258
2 changes: 1 addition & 1 deletion packages/engine/Source/Renderer/Context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1409,7 +1409,7 @@ Context.prototype.draw = function (
//>>includeEnd('debug');

passState = defaultValue(passState, this._defaultPassState);
// The command's framebuffer takes presidence over the pass' framebuffer, e.g., for off-screen rendering.
// The command's framebuffer takes precedence over the pass' framebuffer, e.g., for off-screen rendering.
const framebuffer = defaultValue(
drawCommand._framebuffer,
passState.framebuffer
Expand Down
Loading