-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #1534] Hamburger Menu Now Has 2 Size Classes for Smaller / Larger Scenarios #1535
base: master
Are you sure you want to change the base?
[Fixes #1534] Hamburger Menu Now Has 2 Size Classes for Smaller / Larger Scenarios #1535
Conversation
…ension Variable since Navbar
Is this blocked on anything? |
Not that I know of @bb010g, simply waiting for this to be merged in. |
hey @jgthms ! Can we have your input on this? Any chance to merge? |
this seems to have gotten stale. +1 though |
this is still needed! can we merge it? |
Yes, this is a much-needed feature... are there any temporary workarounds we can use to change the burger's size in the meantime? |
Bumped into this MR because I was looking for a way to increase hamburger size as well. Would be nice if it could still be merged in. |
Now this would really be a nice option to have... but in the meantime, i did this... it's ugly and barely works:
|
any follow up on this ? |
It would be great if this could be merged. |
works kinda for me too, like you mentioned barely works. Would love to have this option as well natively |
This is a bugfix which resulted in an improvement.
Fixes #1534
Proposed solution
Fixes the Hamburger responsive concept by adding two new classes
is-small
andis-large
which reduce or expand the dimensions of the hamburger menu spans.Tradeoffs
No trade offs that I can think of, since this is entirely style-sheet class driven.
Examples in testing.
Testing Done
#1534 contains the final testing, which @jimblue concluded was appropriate for the required bugfix / improvement. @jgthms, if you have any issues with this improvement / bugfix, I'd be happy to correct.