Translation optimization and image selector integration #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integrate the image_selector into the tools directory
Correct the GalleryImageSelector to properly handle the case when a file cannot be created due to an IOException. This change adds the exceptionhandling where it was previously missing.
Added detailed JavaDoc comments to the GalleryImageSelector class, explaining its usage, constructor parameters, and the process of integrating it into an Android application. This includes specifying the necessary manifest and XML configurations for file providers. The comments also describe the workflow for image selection, cropping, and saving within the app's internal storage.
|
Provide some screenshots of the results plz |
Ok, but actually they don't look any different.
|
|
Sorry for taking so long for the review (I was working on RTranslator 2.1), the changes seem perfect, ready for merge, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize some Simplified Chinese translations and integrate image selector into the code.