Ensure that we always emit a diagnostic for JSON5 errors #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@DeMoorJasper This might throw a diagnostic with a codeframe but errors in a reporter don't go through the CLIReporter / prettifyDiagnostic. How should we handle this? Make the server reporter run prettifyDiagnostic?
|
|
@mischnic we can add a try/catch in the server reporter and manually dispatch it to the logger using |
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js x4 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... |
|
👍 That causes the error to be swallowed by the |
|
@mischnic I originally wanted to do it but ran into infinite loops pretty quickly so went with what we currently have, we could also detect such an infinite loop and bail out that point though... but seems like a bit more work. Feel free to suggest an alternative or help me figure out how to detect an infinite loop in that case |
|
I would say it's fine as it is. I'll just have to figure out how to make that message persist |
|
Just dropping a note to emphasize the importance of this, since it seems like it may have stagnated. I'm in the process of porting my codebase to TS, so lots of code churn in between test runs. Somewhere along the way I started getting the error, below. The one thing conspicuously missing from this error is any mention of the Had I not gotten lucky and guessed that tsconfig might be the source of the issue, this could have easily sucked an hour or more of my time trying to manually bisect all of the changes I'd stacked up. |
|
We previously already added a workaround for Babel config which can also be JSON5: #7022, so maybe for tsconfig as well |
1 task
mischnic
force-pushed
the
json5-diagnostic
branch
from
3c6f0e9
to
4e21368
Compare
mischnic
force-pushed
the
json5-diagnostic
branch
3 times, most recently
from
0d36b0b
to
9c68835
Compare
mischnic
force-pushed
the
json5-diagnostic
branch
from
9c68835
to
09289f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Pull JSON5 parsing & creation of a diagnostic with codeframe into utils and use everywhere.
Inspired by #4863