Add bundle builds #6194

aminya · 2021-04-27T07:23:25Z

↪️ Pull Request

This PR tries to add bundle builds for Parcel to speed up loading time. The plan is to provide a parcel-bundle binary that uses the bundled builds instead of the source files. This is the second take on Bundle CSSNano optimizer (make Parcel 2-5 s faster) #5671, but without modifying the default behavior of the packages (with parcel binary).
It's always a very good test to use a tool on itself. Bundling Parcel using Parcel can reveal many bugs, and also result in improving the Parcel code itself.

💻 Examples

🚨 Test instructions

✔️ PR Todo

Added/updated unit tests for this change
Filled out test instructions (In case there aren't any unit tests)
Included links to related issues/PRs

height · 2021-04-27T07:23:27Z

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

aminya · 2021-04-27T07:59:52Z

packages/core/parcel/package.json

+    "bundle": {
+      "context": "node",
+      "includeNodeModules": {
+        "@parcel/core": false,


Failed because of require.resolve('./worker')

aminya · 2021-04-27T08:01:49Z

packages/core/parcel/package.json

+        "@parcel/fs": false,
+        "@parcel/package-manager": false,


Creates a cryptic error when the bundle is used.

Error: Name already registered with serializer at registerSerializableClass (C:\parcel\packages\core\core\lib\serializer.js:43:11) at Object.<anonymous> (C:\parcel\packages\core\fs\lib\NodeFS.js:229:39) at Module.n._compile (C:\parcel\packages\core\parcel\lib\bin.bundle.js:64:1076211) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1137:10) at Module.load (node:internal/modules/cjs/loader:988:32) at Function.Module._load (node:internal/modules/cjs/loader:828:14) at Module.require (node:internal/modules/cjs/loader:1012:19) at o (C:\parcel\packages\core\parcel\lib\bin.bundle.js:64:1075905) at Object.<anonymous> (C:\parcel\packages\core\fs\lib\index.js:21:15) at Module.n._compile (C:\parcel\packages\core\parcel\lib\bin.bundle.js:64:1076211) ERROR Command failed with exit code 1.

aminya · 2021-04-27T08:02:13Z

packages/core/parcel/package.json

+        "@parcel/core": false,
+        "@parcel/fs": false,
+        "@parcel/package-manager": false,
+        "@parcel/fs-search": false


The prebuild relies on the location of the file.

aminya · 2021-04-27T08:03:35Z

packages/core/parcel/package.json

@@ -38,5 +42,20 @@
  },
  "devDependencies": {
    "@parcel/babel-register": "2.0.0-beta.2"
+  },
+  "scripts": {
+    "bundle": "cross-env NODE_ENV=production parcel build --target bundle lib/bin.js --no-scope-hoist"


Scope hoisting results in this error when the bundle is used:

TypeError: Class extends value #<Object> is not a constructor or null at $e0ff572d13646e06f40e076cefd6686f$exec (C:\parcel\packages\core\parcel\lib\bin.bundle.js:25:1424680) at $e0ff572d13646e06f40e076cefd6686f$init (C:\parcel\packages\core\parcel\lib\bin.bundle.js:25:1443053) at $ee4cb4f5c2d240a4c58df653433665f4$var$_commander (C:\parcel\packages\core\parcel\lib\bin.bundle.js:25:1447963) at Object.<anonymous> (C:\parcel\packages\core\parcel\lib\bin.bundle.js:25:1454346) at Module._compile (node:internal/modules/cjs/loader:1108:14) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1137:10) at Module.load (node:internal/modules/cjs/loader:988:32) at Function.Module._load (node:internal/modules/cjs/loader:828:14) at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12) at node:internal/main/run_main_module:17:47

aminya · 2021-04-27T08:05:34Z

packages/core/parcel/package.json

@@ -54,8 +54,7 @@
        "@parcel/fs": false,
        "@parcel/package-manager": false,
        "@parcel/fs-search": false,
-        "highlight.js": false,
-        "node-forge": false


node-forge makes the bundle very large. Although not all of its exports are used.

Made a pull request to fix this issue: #6198

aminya · 2021-04-27T08:06:04Z

packages/core/parcel/package.json

@@ -54,8 +54,7 @@
        "@parcel/fs": false,
        "@parcel/package-manager": false,
        "@parcel/fs-search": false,
-        "highlight.js": false,


highlight-js makes the bundle very large. Although many of its required languages are not used.

Made a pull request to fix this issue
#6196

mischnic · 2021-04-27T23:36:21Z

Is this significantly faster for you? Because all of the plugins as specified in the parcelrc are still unbundled

aminya · 2021-04-28T03:50:51Z

Is this significantly faster for you? Because all of the plugins as specified in the parcelrc are still unbundled

This isn't ready yet. It's just the start. Also, the improvements shouldn't be measured only based on build time. As I mentioned in the OP, it's always a very good test to use a tool on itself. Bundling Parcel using Parcel can reveal many bugs, and also result in improving the Parcel code itself.

So far I have extracted these two pull requests from this pull request which are helpful even for the default Parcel binary.
#6196
#6198

mischnic · 2021-04-28T08:51:11Z

As I mentioned in the OP, it's always a very good test to use a tool on itself. Bundling Parcel using Parcel can reveal many bugs, and also result in improving the Parcel code itself.

This isn't the first effort to do that: https://parcel2-repl.vercel.app

aminya · 2021-04-28T09:28:51Z

Thanks. In addition to the benefits I mentioned before, these changes (like the fixes I have done in the other two PRs) will reduce the payload size significantly.

I am anticipating that the main build-time performance benefits start to show themselves when we bundle the plugins such as cssnano. I already showed this in #5671. Just bundling CSSNano reduced the build time by 2-5 seconds. This is a "constant overhead" that anyone who uses CSS will pay! By the new parcel-bundle binary, these overheads are removed (for those who optionally use it).

I am going to take a look at the source code of the REPL to see which parts I can borrow for parcel-bundle.

aminya force-pushed the bundle-builds branch from 669ab94 to 45388c5 Compare April 27, 2021 07:45

aminya commented Apr 27, 2021

View reviewed changes

This was referenced Apr 29, 2021

Lazy load node-forge only if needed (Make Parcel ~300KB smaller) #6198

Open

"Name already registered with serializer" with parcel@next #4064

Closed

eval require if it is not a property of module #6219

Open

aminya added 11 commits May 9, 2021 20:30

Add bundle builds

edbdccf

Include node-forge

3143185

Include highlight-js

3008b8d

Directly build the src

62afea8

Do not babel transform modules in bundle

fbcaec6

Generate commonjs outputFormat

650727c

Exclude @parcel/source-map from the bundle (due to node-gyp-build bug)

67acd6b

Link current parcel binary to node_modules before build:bundle

daf9490

Use path.join instead of require.resolve for workerPath

d589de2

Bundle @parcel/core and its worker

00af7cf

Eval require if it is not a property of module

151e50b

aminya force-pushed the bundle-builds branch from 8320b5b to 151e50b Compare May 10, 2021 01:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add bundle builds #6194

Add bundle builds #6194

aminya commented Apr 27, 2021 •

edited

Loading

height bot commented Apr 27, 2021

aminya Apr 27, 2021

aminya Apr 27, 2021 •

edited

Loading

aminya Apr 27, 2021 •

edited

Loading

aminya Apr 27, 2021

aminya Apr 27, 2021 •

edited

Loading

aminya Apr 27, 2021

aminya Apr 27, 2021 •

edited

Loading

aminya Apr 27, 2021 •

edited

Loading

mischnic commented Apr 27, 2021

aminya commented Apr 28, 2021 •

edited

Loading

mischnic commented Apr 28, 2021

aminya commented Apr 28, 2021 •

edited

Loading

Add bundle builds #6194

Are you sure you want to change the base?

Add bundle builds #6194

Conversation

aminya commented Apr 27, 2021 • edited Loading

↪️ Pull Request

💻 Examples

🚨 Test instructions

✔️ PR Todo

height bot commented Apr 27, 2021

aminya Apr 27, 2021

Choose a reason for hiding this comment

aminya Apr 27, 2021 • edited Loading

Choose a reason for hiding this comment

aminya Apr 27, 2021 • edited Loading

Choose a reason for hiding this comment

aminya Apr 27, 2021

Choose a reason for hiding this comment

aminya Apr 27, 2021 • edited Loading

Choose a reason for hiding this comment

aminya Apr 27, 2021

Choose a reason for hiding this comment

aminya Apr 27, 2021 • edited Loading

Choose a reason for hiding this comment

aminya Apr 27, 2021 • edited Loading

Choose a reason for hiding this comment

mischnic commented Apr 27, 2021

aminya commented Apr 28, 2021 • edited Loading

mischnic commented Apr 28, 2021

aminya commented Apr 28, 2021 • edited Loading

aminya commented Apr 27, 2021 •

edited

Loading

aminya Apr 27, 2021 •

edited

Loading

aminya Apr 27, 2021 •

edited

Loading

aminya Apr 27, 2021 •

edited

Loading

aminya Apr 27, 2021 •

edited

Loading

aminya Apr 27, 2021 •

edited

Loading

aminya commented Apr 28, 2021 •

edited

Loading

aminya commented Apr 28, 2021 •

edited

Loading