fix(DASH): Evict (by time) indexes in MetaSegmentIndex (#7296)

Issue #6239
shaka-project · Sep 13, 2024 · 47c5562 · 47c5562
1 parent 8131b91
commit 47c5562
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/lib/media/segment_index.js b/lib/media/segment_index.js
@@ -834,10 +834,10 @@ shaka.media.MetaSegmentIndex = class extends shaka.media.SegmentIndex {
    * @export
    */
   evict(time) {
-    // evict() is only used internally by the DASH and HLS parser on
-    // SegmentIndexes, but never on MetaSegmentIndex.
-    goog.asserts.assert(
-        false, 'evict() should not be used in MetaSegmentIndex!');
+    for (const index of this.indexes_) {
+      index.evict(time);
+    }
+    this.evictEmpty();
   }
 
   /**

diff --git a/lib/media/streaming_engine.js b/lib/media/streaming_engine.js
@@ -2505,7 +2505,8 @@ shaka.media.StreamingEngine = class {
   async evict_(mediaState, presentationTime) {
     const segmentIndex = mediaState.stream.segmentIndex;
     if (segmentIndex instanceof shaka.media.MetaSegmentIndex) {
-      segmentIndex.evictEmpty();
+      segmentIndex.evict(
+          this.manifest_.presentationTimeline.getSeekRangeStart());
     }
 
     const logPrefix = shaka.media.StreamingEngine.logPrefix_(mediaState);