fix(HLS): Fix uncaught error in slow network scenario #7321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
|
Incremental code coverage: 100.00% |
joeyparrish
reviewed
Sep 16, 2024
| mediaState.segmentIterator = | ||
| mediaState.stream.segmentIndex.getIteratorForTime( | ||
| time, /* allowNonIndepedent= */ false, reverse); | ||
| if (mediaState.stream.segmentIndex) { |
There was a problem hiding this comment.
If this is null, is segmentIterator always null already?
joeyparrish
approved these changes
Sep 16, 2024
avelad
added a commit
that referenced
this pull request
Sep 18, 2024
This case can occur with a live HLS in which the playlist timeout errors and that playlist is deactivated and changed to another one and this other one takes a long time to be received.
avelad
added a commit
that referenced
this pull request
Sep 18, 2024
This case can occur with a live HLS in which the playlist timeout errors and that playlist is deactivated and changed to another one and this other one takes a long time to be received.
joeyparrish
pushed a commit
that referenced
this pull request
Sep 18, 2024
This case can occur with a live HLS in which the playlist timeout errors and that playlist is deactivated and changed to another one and this other one takes a long time to be received.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This case can occur with a live HLS in which the playlist timeout errors and that playlist is deactivated and changed to another one and this other one takes a long time to be received.