Use the firebase-admin package instead of firebase to push benchmark results #6711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linchenn
reviewed
Aug 2, 2022
There was a problem hiding this comment.
LGTM! Also, thank you for correcting the scripts!
Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055)
Linchenn
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @pyu10055)
pyu10055
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the firebase package with firebase-admin. The firebase-admin package is more appropriate for our use case of running benchmarks in GCP and pushing them to Firestore. Per their docs, "The Firebase Admin Node.js SDK enables access to Firebase services from privileged environments (such as servers or cloud) in Node.js." It uses application default credentials, which are available in GCP.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is