Refactor and improve animation logic. #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to split the refactoring and logic changes out from the demo CSS changes so they're isolated. |
|
Updated this PR to remove the changes to the development demo |
|
The demo CSS changes are now in #296. |
| } else { | ||
| spf.tasks.suspend(key); // Suspend main queue for animation. | ||
| var animationKey = spf.tasks.key(el); | ||
|
|
- Make the start state more reliable by delaying for 17ms (1 frame at 60 frames/second) before running the animation. - Refactor the animation logic into separate dedicated functions for clarity: prepare, run, complete. - Store animation-related data in a dedicated object. - Rename a couple DOM methods to better communicate what they do.
|
Extra blank lines removed. |
|
lgtm |
nicksay
added a commit
that referenced
this pull request
Feb 18, 2015
Refactor and improve animation logic.
|
Post-commit associating this with #299. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1 frame at 60 frames/second) before running the animation.
clarity: prepare, run, complete.